Tíquete #43747

Client does not resend desired server settings after ruleset change

: 2022-02-01 10:55 Última Atualização: 2022-08-05 08:57

Relator:
Dono:
(Nenhum)
Tipo:
Estado:
Aberto
Componente:
Marcos:
Prioridade:
5 - Medium
Gravidade:
5 - Medium
Resolução:
Nenhum
Arquivo:
2

Details

Reported by Dino the Dinosore in http://forum.freeciv.org/f/viewtopic.php?f=9&t=92134#p104834

Server settings saved on client side ("desired settings") are not used if one changes the ruleset, i.e., does not use the default. The server does reset settings when a new ruleset is loaded, and I guess the client does not resend the desired settings after that.

Ticket History (3/10 Histories)

2022-02-01 10:55 Updated by: cazfi
  • New Ticket "Client does not resend desired server settings after ruleset change" created
2022-02-01 11:45 Updated by: cazfi
  • Dono Update from (Nenhum) to cazfi
2022-02-13 10:10 Updated by: cazfi
  • Resolução Update from Nenhum to Accepted
2022-02-19 15:41 Updated by: cazfi
  • Resolução Update from Accepted to Nenhum
Comentário

Keeping this one on hold for now. I think that together with #43748 the *fix* causes any ruleset one changes to get polluted by settings from the default ruleset game.ruleset.

2022-03-18 04:44 Updated by: cazfi
Comentário

Reply To cazfi

Keeping this one on hold for now.

I don't believe this can happen before 3.0.1

2022-04-09 07:56 Updated by: cazfi
Comentário

There's also regression related to 'topology' setting. This causes it to get sent also when saved game is loaded, triggering server's error about the fact that the setting cannot be changed after game has begun.

2022-06-11 21:52 Updated by: cazfi
2022-08-05 08:57 Updated by: cazfi

Editar

You are not logged in. I you are not logged in, your comment will be treated as an anonymous post. » Login