savegame unquote_block() sanity check not in NDEBUG build

• Relator: cazfi
• Dono: cazfi
• Tipo: Bugs
• Estado: Fechado
• Componente: Server
• Marcos: 3.0.2 (fechado)
• Prioridade: 5 - Medium
• Gravidade: 5 - Medium
• Resolução: Fixed
• Arquivo: 2

Details

Noticed on S3_0: Both savegame2.c and savegame3.c have unquote_block() asserting that number of items from sscanf() is 1. I think that sanity check (which might even be for external data - haven't investigated closely) should happen also when asserts are not enabled.

Ticket History (3/5 Histories)

2022-03-27 17:58 Updated by: cazfi

• New Ticket "savegame unquote_block() sanity check not in NDEBUG build" created

2022-04-13 03:37 Updated by: cazfi

• File 0042-savegame-Turn-unquote_block-asserts-to-sanity-checks.patch (File ID: 8992) is attached

2022-04-13 03:37 Updated by: cazfi

• File 0020-savegame-Turn-unquote_block-asserts-to-sanity-checks.patch (File ID: 8993) is attached

2022-04-13 03:37 Updated by: cazfi

• Dono Update from (Nenhum) to cazfi
• Resolução Update from Nenhum to Accepted

2022-04-23 05:08 Updated by: cazfi

• Estado Update from Aberto to Fechado
• Resolução Update from Accepted to Fixed