Fix illegal movements by edit.unit_move()

• Relator: ihnatus
• Dono: cazfi
• Tipo: Bugs
• Estado: Fechado
• Componente: Scripting API
• Marcos: 3.0.5 (fechado)
• Prioridade: 5 - Medium
• Gravidade: 5 - Medium
• Resolução: Fixed
• Arquivo: 2

Details Responder

I was pretty sure that calling (Archers):move(TileNearbyWithEnemyMigrants, 1) will make the Archers capture the Migrants, or at worst case it will be blocked, but in fact it puts the archers on the same tile with enemy units without capturing them. Likely, it can create other illegal positions. Btw, I can't understand, would 3.0 or later method ever do some actions you'd expect from emulating arrow key pressed by Lua.

Ticket History (3/8 Histories)

2022-06-07 04:01 Updated by: ihnatus

• New Ticket "Fix illegal movements by edit.unit_move()" created

2022-06-07 04:10 Updated by: cazfi

Comentário Responder

Reply To ihnatus

would 3.0 or later method ever do some actions you'd expect from emulating arrow key pressed by Lua.

Given how goto-moves cannot handle them (e.g. #44496), I'm not overly optimistic.

2022-08-05 08:59 Updated by: cazfi

• Marco Update from 3.0.3 (fechado) to 3.0.4 (fechado)

2022-10-07 09:29 Updated by: cazfi

• Marco Update from 3.0.4 (fechado) to 3.0.5 (fechado)

2022-11-26 22:58 Updated by: cazfi

• File 0041-lua-Check-legality-of-unit_move-and-unit_teleport.patch (File ID: 10939) is attached

2022-11-26 22:58 Updated by: cazfi

• File 0023-lua-Check-legality-of-unit_move-and-unit_teleport.patch (File ID: 10940) is attached

2022-11-26 23:01 Updated by: cazfi

• Dono Update from (Nenhum) to cazfi
• Resolução Update from Nenhum to Accepted

Comentário Responder

Attached patches should do it - not properly tested yet. For S3_0 will need also to check that passing NULL as embark_to isn't compatibility break (is the traditional behavior to embark to automatically selected transport?)

2022-12-04 07:52 Updated by: cazfi

• Estado Update from Aberto to Fechado
• Resolução Update from Accepted to Fixed