kill_unit() constantly calling player_slot_count()

• Relator: cazfi
• Dono: cazfi
• Tipo: Bugs
• Estado: Fechado
• Componente: Server
• Marcos: 3.0.3 (fechado)
• Prioridade: 5 - Medium
• Gravidade: 5 - Medium
• Resolução: Fixed
• Arquivo: 1

Details

kill_unit() calls player_slot_count() many times. The value returned will be the same every time, so should just call it once, and store the value in a variable. This should also help with some clang analyzer warnings that alerted me to this issue - compiler cannot know that each of those calls return the same value.

Ticket History (3/4 Histories)

2022-06-11 21:47 Updated by: cazfi

• New Ticket "kill_unit() constantly calling player_slot_count()" created

2022-06-21 22:53 Updated by: cazfi

• File 0056-kill_unit-Call-player_slot_count-just-once.patch (File ID: 9574) is attached

2022-06-21 22:53 Updated by: cazfi

• Dono Update from (Nenhum) to cazfi
• Resolução Update from Nenhum to Accepted

2022-06-29 06:25 Updated by: cazfi

• Estado Update from Aberto to Fechado
• Resolução Update from Accepted to Fixed