Don't record that barbarians execute ambassadors

• Relator: ihnatus
• Dono: cazfi
• Tipo: Bugs
• Estado: Fechado
• Componente: Server
• Marcos: 3.0.5 (fechado)
• Prioridade: 5 - Medium
• Gravidade: 5 - Medium
• Resolução: Fixed
• Arquivo: 1

Details

They don't do it since v.2.6 already. You can (potentially) establish an embassy to a player with "NoDiplomacy" effect, you just can't meet. So ULR_EXECUTED is unused except maybe by a script.

We should make it clear from help and code comments (server/diplomats.c) that barbarians won't execute the diplomat. We might bring back the "oh, I forgot I can't do it to barbarians!" gameplay with a script callback if we have a way to make AI diplomats not fumble this way too often.

Ticket History (3/7 Histories)

2022-06-20 07:06 Updated by: ihnatus

• New Ticket "Don't record that barbarians execute ambassadors" created

2022-08-05 09:00 Updated by: cazfi

• Marco Update from 3.0.3 (fechado) to 3.0.4 (fechado)

2022-08-07 22:05 Updated by: cazfi

Comentário

Reply To ihnatus

We should make it clear from help and code comments (server/diplomats.c)

Is there misleading help / documentation currently? Function header for diplomat_embassy() is the only place where I saw that mentioned.

2022-10-07 09:31 Updated by: cazfi

• Marco Update from 3.0.4 (fechado) to 3.0.5 (fechado)

2022-12-05 03:46 Updated by: cazfi

• File 0039-Correct-diplomat_embassy-header.patch (File ID: 11027) is attached

2022-12-05 03:47 Updated by: cazfi

• Dono Update from (Nenhum) to cazfi
• Resolução Update from Nenhum to Accepted
• Componente Update from General to Server

Comentário

Reply To cazfi

Reply To ihnatus

We should make it clear from help and code comments (server/diplomats.c)

Is there misleading help / documentation currently? Function header for diplomat_embassy() is the only place where I saw that mentioned.

So that header is the only thing this patch touches.

2022-12-10 13:31 Updated by: cazfi

• Estado Update from Aberto to Fechado
• Resolução Update from Accepted to Fixed