Resolving "unused entry" warnings about diplstates in stable branches -> #45527
Diplstate order actually IS loaded in savegame2.c case. For some reason that has not made it to savegame3.c
Reply To cazfi
Diplstate order actually IS loaded in savegame2.c case. For some reason that has not made it to savegame3.c
The thing seems to be that savegame3.c does not save values as integers, but by name. So there's no need to have the order (mapping from integers to names) in the savegame.
So, this ticket turns to one to stop saving the useless information on savegame3.c.
Diplstate order is being saved to the savegame, but it's not used in the loading side.
Presumably the reason for that the saving side has been implemented in earlier versions already is for the benefit of newer versions loading such savegames - no need to keep the order present in "historical" versions listed in the newer version binary.
We should implement the loading side too. Targeting initially to master only, but should also confirm that S3_1 still has the same hardcoded order as the earlier versions (so it's ok to keep using that hardcoded order)