Disallow changing ruleset when fixed one given from commandline

• Relator: cazfi
• Dono: cazfi
• Tipo: Patches
• Estado: Fechado
• Componente: Server
• Marcos: 3.2.0
• Prioridade: 5 - Medium
• Gravidade: 5 - Medium
• Resolução: Fixed
• Arquivo: 2

Details

If freeciv-server has been launched with specific ruleset given at commandline, it makes sense not to allow (regular) users within the server to change that.

As current behavior is not strictly a bug, and some users may rely on it, targeting this to master only, as a behavior change.

Ticket History (3/7 Histories)

2022-07-07 06:00 Updated by: cazfi

• New Ticket "Disallow changing ruleset when fixed one given from commandline" created

2022-07-07 06:52 Updated by: cazfi

• File 0049-Prohibit-changing-ruleset-given-from-commandline.patch (File ID: 9754) is attached

2022-07-07 06:53 Updated by: cazfi

• Dono Update from (Nenhum) to cazfi
• Resolução Update from Nenhum to Accepted

2022-07-16 08:02 Updated by: cazfi

• Resolução Update from Accepted to Nenhum

Comentário

Current patch causes trouble in case the client inadvertently has such a tileset active that it triggers initial server setup with wrong ruleset.

2022-07-17 17:04 Updated by: cazfi

• File 0008-Prohibit-changing-ruleset-given-from-commandline.patch (File ID: 9829) is attached

2022-07-17 17:05 Updated by: cazfi

• Resolução Update from Nenhum to Accepted

Comentário

The new version brings the restriction only to is_restricted() connections - so the client that forked the server can still change the ruleset.

2022-07-21 20:17 Updated by: cazfi

• Estado Update from Aberto to Fechado
• Resolução Update from Accepted to Fixed