Rulesave: Save action enablers to actions.ruleset

• Relator: cazfi
• Dono: cazfi
• Tipo: Patches
• Estado: Fechado
• Componente: Ruledit and ruleup
• Marcos: 3.2.0
• Prioridade: 5 - Medium
• Gravidade: 5 - Medium
• Resolução: Fixed
• Arquivo: 2

Details

Split from #41572

Change rulesave.c to save action enablers to actions.ruleset instead of game.ruleset.

Ticket History (3/10 Histories)

2022-07-08 16:34 Updated by: cazfi

• New Ticket "Rulesave: Save action enablers to actions.ruleset" created

2022-07-19 04:35 Updated by: dark-ether

• File 0003-tools-ruleutil-rulesave.c-made-rulesave-save-action-.patch (File ID: 9846) is attached

2022-07-21 07:19 Updated by: cazfi

Comentário

Please add also a comment when attaching a patch (or any file). osdn does not send notification emails about new attachments, so they alone usually go unnoticed.

2022-12-23 07:55 Updated by: cazfi

• File 0043-Rulesave-Save-actions-to-actions.ruleset.patch (File ID: 11174) is attached

2022-12-23 07:59 Updated by: cazfi

• Dono Update from (Nenhum) to cazfi
• Resolução Update from Nenhum to Accepted

Comentário

With #45064 resolved this can now go forward.

Git warned about trailing whitespace being added when applying the patch. Instead of trying to find what that exact (new) one was, I simply cleared all trailing whitespaces from rulesave.c. Patch version with that change attached.

2022-12-25 05:47 Updated by: cazfi

• Resolução Update from Accepted to Nenhum

Comentário

I've found some issues that need to be resolved first. One is #46350, for the other I'm yet to open a ticket (need to find out more details)

2022-12-25 17:35 Updated by: cazfi

Comentário

Reply To cazfi

for the other I'm yet to open a ticket (need to find out more details)

-> #46360

Blocks this, since the CI tests would start failing with this pushed first.

2022-12-30 09:57 Updated by: cazfi

• Resolução Update from Nenhum to Accepted

Comentário

Known issues (the dependency tickets - no changes to this patch) resolved, let's try again.

2022-12-31 15:40 Updated by: cazfi

Comentário

Still needs #46399 first.

2023-01-03 13:05 Updated by: cazfi

• Estado Update from Aberto to Fechado
• Resolução Update from Accepted to Fixed