Failing "punit->homecity == pcity->id" asserts for NoHome units

• Relator: cazfi
• Dono: cazfi
• Tipo: Bugs
• Estado: Fechado
• Componente: Server
• Marcos: 3.1.0 (fechado)
• Prioridade: 5 - Medium
• Gravidade: 5 - Medium
• Resolução: Fixed
• Arquivo: 3

Details

Overzealous asserts in place_unit() and check_city_good() fail for NoHome units.

Ticket History (3/8 Histories)

2022-07-23 15:06 Updated by: cazfi

• New Ticket "Failing "punit->homecity == pcity->id" asserts for NoHome units" created

2022-07-23 15:14 Updated by: cazfi

• File 0056-Fix-overzealous-asserts-against-NoHome-units.patch (File ID: 9900) is attached

2022-07-23 15:15 Updated by: cazfi

• File 0021-Fix-overzealous-asserts-against-NoHome-units.patch (File ID: 9901) is attached

2022-07-23 15:15 Updated by: cazfi

• Dono Update from (Nenhum) to cazfi
• Resolução Update from Nenhum to Accepted
• Marco Update from (Nenhum) to 3.0.3 (fechado)

Comentário

S3_0 version to be applied to S2_6 too

2022-07-24 11:52 Updated by: cazfi

• Resolução Update from Accepted to Nenhum
• Marco Update from 3.0.3 (fechado) to (Nenhum)

Comentário

Maybe those asserts are not overzealous, but they have been detecting an actual bug. They are in the context of units in city.units_supported, so there should NOT be any NoHome units there.

2022-07-25 02:22 Updated by: cazfi

• File 0044-place_unit-Do-not-add-NoHome-units-to-city-s-units_s.patch (File ID: 9912) is attached

2022-07-25 02:22 Updated by: cazfi

• Resolução Update from Nenhum to Accepted
• Marco Update from (Nenhum) to 3.1.0 (fechado)

Comentário

Actual bugfix attached. master & S3_1 affected.

2022-07-29 17:58 Updated by: cazfi

• Estado Update from Aberto to Fechado
• Resolução Update from Accepted to Fixed