Stop saving "game.hardcoded_counters"

• Relator: cazfi
• Dono: cazfi
• Tipo: Bugs
• Estado: Fechado
• Componente: Server
• Marcos: S3_2 d3f (fechado)
• Prioridade: 5 - Medium
• Gravidade: 5 - Medium
• Resolução: Fixed
• Arquivo: 3

Details

Counters are no longer hardcoded, so we should not save "game.hardcoded_counters" any more and especially not as TRUE!

The "unused entry" warning should be silenced from dev savegames (in "< 3019300" block of compat_load_dev() )

Ticket History (3/17 Histories)

2022-09-08 01:21 Updated by: cazfi

• New Ticket "Stop saving "game.hardcoded_counters"" created

2022-09-24 21:01 Updated by: lachu

• File 0001-OSDN-45603-S-awomir-Lach-slawek-lach.art.pl.patch (File ID: 10379) is attached

2022-09-24 21:02 Updated by: lachu

Comentário

@cazfi

0001-OSDN-45603-S-awomir-Lach-slawek-lach.art.pl.patch(1KB)

I hope this address problem you're asking to solve

2022-09-24 21:08 Updated by: cazfi

Comentário

- Remove also the loading part.
- The compat change should be one to silence "unused entry" -warning (try to run with --warnings) when the loading part is removed from the savegame3.c: likely just "(void) secfile_entry_lookup(...)"

2022-09-25 01:17 Updated by: lachu

Comentário

Reply To cazfi

- Remove also the loading part.
- The compat change should be one to silence "unused entry" -warning (try to run with --warnings) when the loading part is removed from the savegame3.c: likely just "(void) secfile_entry_lookup(...)"

Hi. I am nowhere. I cannot found if there is a still loading part. I search for hardcoded counters in savegame3.c.

2022-09-25 01:20 Updated by: cazfi

Comentário

Reply To lachu

I am nowhere. I cannot found if there is a still loading part. I search for hardcoded counters in savegame3.c.

Right, There wasn't. That actually was how I encountered the problem - I got the "unused entry" warning as the entry is never loaded. So; we need to stop saving the field to new savegames (your patch already did that) and to silence the warning with secfile_entry_lookup() while loading those savegames where it was saved to.

2022-09-25 01:41 Updated by: lachu

• File 0001-OSDN-45603-S-awomir-Lach-slawek-lach.art.pl.patch (File ID: 10387) is attached
• File 0001-OSDN-45603-S-awomir-Lach-slawek-lach.art.pl.patch (File ID: 10386) is attached
• File 0001-OSDN-45603-S-awomir-Lach-slawek-lach.art.pl.patch (File ID: 10383) is attached
• File 0001-OSDN-45603-S-awomir-Lach-slawek-lach.art.pl.patch (File ID: 10385) is attached
• File 0001-OSDN-45603-S-awomir-Lach-slawek-lach.art.pl.patch (File ID: 10384) is attached

2022-09-25 01:41 Updated by: lachu

• File 0001-OSDN-45603-S-awomir-Lach-slawek-lach.art.pl.patch (File ID: 10387) is deleted

2022-09-25 01:41 Updated by: lachu

• File 0001-OSDN-45603-S-awomir-Lach-slawek-lach.art.pl.patch (File ID: 10386) is deleted

2022-09-25 01:41 Updated by: lachu

• File 0001-OSDN-45603-S-awomir-Lach-slawek-lach.art.pl.patch (File ID: 10385) is deleted

2022-09-25 01:41 Updated by: lachu

• File 0001-OSDN-45603-S-awomir-Lach-slawek-lach.art.pl.patch (File ID: 10384) is deleted

2022-09-25 01:42 Updated by: lachu

Comentário

Reply To cazfi

Reply To lachu

I am nowhere. I cannot found if there is a still loading part. I search for hardcoded counters in savegame3.c.

Right, There wasn't. That actually was how I encountered the problem - I got the "unused entry" warning as the entry is never loaded. So; we need to stop saving the field to new savegames (your patch already did that) and to silence the warning with secfile_entry_lookup() while loading those savegames where it was saved to.

0001-OSDN-45603-S-awomir-Lach-slawek-lach.art.pl.patch(1KB)

Change from secfile_load_bool into secfile_load_entry

This should work as expected.

2022-09-25 03:28 Updated by: cazfi

Comentário

Looks good, but does not apply to master HEAD.

2022-09-25 18:48 Updated by: lachu

• File 0001-OSDN-45603-S-awomir-Lach-slawek-lach.art.pl.patch (File ID: 10392) is attached

2022-09-25 18:48 Updated by: lachu

Comentário

Reply To cazfi

Looks good, but does not apply to master HEAD.

0001-OSDN-45603-S-awomir-Lach-slawek-lach.art.pl.patch(1KB)

It should apply

2022-09-25 20:01 Updated by: cazfi

• Dono Update from (Nenhum) to cazfi
• Resolução Update from Nenhum to Accepted

2022-09-27 21:05 Updated by: cazfi

• Estado Update from Aberto to Fechado
• Resolução Update from Accepted to Fixed