Savegame loading: Unused worklist entries

• Relator: cazfi
• Dono: cazfi
• Tipo: Bugs
• Estado: Fechado
• Componente: Server
• Marcos: 3.0.5 (fechado)
• Prioridade: 5 - Medium
• Gravidade: 5 - Medium
• Resolução: Fixed
• Arquivo: 3

Details

Loading savegames with deprecation warnings enabled (sometimes) give unused entry warnings about likes of 'player25.c135.wl_value0' and 'player25.c135.wl_kind0'

It's likely due to loading side looking entries just up to real "wl_length", whereas saving side has padding entries to avoid savegame from going out from tabular format.

Ticket History (3/7 Histories)

2022-09-20 15:36 Updated by: cazfi

• New Ticket "Savegame loading: Unused worklist entries" created

2022-09-23 13:16 Updated by: cazfi

• Marco Update from (Nenhum) to 3.0.5 (fechado)

2022-10-08 08:53 Updated by: cazfi

• File 0034-Fix-unused-entry-warnings-about-worklist-padding-on-.patch (File ID: 10506) is attached

2022-10-08 08:54 Updated by: cazfi

• File 0027-Fix-unused-entry-warnings-about-worklist-padding-on-.patch (File ID: 10507) is attached

2022-10-08 08:54 Updated by: cazfi

• File 0019-Fix-unused-entry-warnings-about-worklist-padding-on-.patch (File ID: 10508) is attached

2022-10-08 08:56 Updated by: cazfi

• Dono Update from (Nenhum) to cazfi
• Resolução Update from Nenhum to Accepted

Comentário

Master version saves the max worklist length (i.e. how much there is padding) to the savegame. d3f branches have to take a bit more expensive route of figuring that out by looking all the city rows from the secfile.

2022-10-13 13:48 Updated by: cazfi

• Estado Update from Aberto to Fechado
• Resolução Update from Accepted to Fixed