S3_0 legacysave.c: base_order handling issue

• Relator: cazfi
• Dono: cazfi
• Tipo: Bugs
• Estado: Fechado
• Componente: Server
• Marcos: 3.0.4 (fechado)
• Prioridade: 5 - Medium
• Gravidade: 5 - Medium
• Resolução: Fixed
• Arquivo: 2

Details

Clang analyzer warns about dead assignment "order_base = base_order[base];" on S3_0 legacysave.c:1619.

Haven't looked closely, but seems to me that there's a real bug in there that it's not used, but the original 'base' gets used (so the base_order gets ignored)

Ticket History (3/6 Histories)

2022-09-23 18:34 Updated by: cazfi

• New Ticket "S3_0 legacysave.c: base_order handling issue" created

2022-09-24 08:13 Updated by: cazfi

• Details Updated

2022-09-24 08:24 Updated by: cazfi

• File 0022-Fix-loading-base-building-orders-from-2.3-savegames.patch (File ID: 10373) is attached

2022-09-24 08:24 Updated by: cazfi

• File 0011-Fix-loading-base-building-orders-from-2.3-savegames.patch (File ID: 10374) is attached

2022-09-24 08:25 Updated by: cazfi

• Dono Update from (Nenhum) to cazfi
• Resolução Update from Nenhum to Accepted
• Marco Update from (Nenhum) to 3.0.4 (fechado)

Comentário

S3_0 and S2_6 affected (the only branches that support legacy saves (< 2.3))

2022-09-26 10:35 Updated by: cazfi

• Estado Update from Aberto to Fechado
• Resolução Update from Accepted to Fixed