city name truncated
Can you attach those savegames?
Reply To cazfi
Can you attach those savegames?
old save, created by the debian qt-client-3.0: https://ufile.io/wmf5j83s
PS: i do not see how to attach a file here, is that correct?
thanks!
new savegame, loaded from the old one using the main branch as of today, with the qt5 client:
Reply To (Anonymous)
PS: i do not see how to attach a file here, is that correct?
At least logged in users have the "Add New attachment" button, but I'm not sure about anonymous users.
Fix attached.
oh ok. Many thanks!
PS: free(NULL) is perfectly valid in C. Let me suggest to remove these superfluous if statements: #47504
cheers!
Reply To cazfi
Reply To (Anonymous)
PS: i do not see how to attach a file here, is that correct?
At least logged in users have the "Add New attachment" button, but I'm not sure about anonymous users.
Right, that's it. anonymous is not allowed to attach files, which makes sense in practise.
I've started a game with the debian package: apt show freeciv-client-qt Package: freeciv-client-qt Version: 3.0.6-1
This (correctly) had the following City names: $ xzgrep -i feldki ~/.freeciv/saves/freeciv-T0260-Y01768-auto.sav.xz 218,457,425,0,3,1,1,0,0,64,0,0,FALSE,-1,0,0,0,136,FALSE,FALSE,207,"Feldkirchen in Kärnten","Building","Supermarket","Building","Supermarket",64,0,0,1,"PostModern",5,"0000000001000000000000000000000000000000000000000000000000000000000000000",5,"Building","Library","Building","Courthouse","Building","Marketplace","Building","Granary","Building","Coinage","","","","","","","","","","",FALSE,FALSE,FALSE,0,0,1,0,0,FALSE,3 218,460,208,0,6,2,0,0,11,14,65,0,FALSE,203,0,0,0,73,FALSE,FALSE,214,"Feldkirch","Building","Granary","Building","Granary",14,0,0,0,"PostModern",5,"0000000001001000010000000000000000000000000000000000000000000000000000000",4,"UnitType","Settlers","Building","Aqueduct","Building","Marketplace","Building","Coinage","","","","","","","","","","","","",FALSE,FALSE,FALSE,0,0,1,0,0,FALSE,6
Then i built the 'main' branch, HEAD == 1f246a4e3dbab8b13a7ba5ba9511ce25ae34138b: $ ./configure --prefix=/opt/x86_64/freeciv --enable-client=qt,gtk3.22 --with-qtver=qt5 qt6 client segfaults for me when instantiating QApplication, but that's for another bug Then, with the QT client, i loaded the game, played, saved.
But now the city names appear to have been truncated: $ zstdgrep -i feldki ~/.freeciv/saves/freeciv-T0293-Y01834-auto.sav.zst 218,457,425,0,5,2,1,0,0,23,0,0,FALSE,FALSE,-1,0,0,0,136,FALSE,FALSE,275,"Feldkir","Building","Library",1,"Building","Library",23,0,0,2,"PostModern",5,"0000000001000000000000000000000000000001000000000000000000000000000000000",4,"Building","Courthouse","Building","Marketplace","Building","Granary","Building","Coinage","","","","","","","","","","",FALSE,FALSE,FALSE,0,0,1,0,0,FALSE,0,0,1,0,0,FALSE,5,0,FALSE,FALSE,"-","-","-",-1,-1,-1,FALSE,0,0,0,0,0,0,0,0,0,0,0,0,FALSE,FALSE,FALSE,FALSE,0 218,460,208,0,6,2,0,0,26,0,98,0,FALSE,FALSE,280,0,0,0,73,FALSE,FALSE,286,"Feldkir","UnitType","Settlers",0,"UnitType","Settlers",0,0,0,0,"PostModern",5,"0000000001001010010000000000000000000000000000000000000000000000000000000",3,"Building","Aqueduct","Building","Marketplace","Building","Coinage","","","","","","","","","","","","",FALSE,FALSE,FALSE,0,0,1,0,0,FALSE,0,0,1,0,0,FALSE,6,0,FALSE,FALSE,"-","-","-",-1,-1,-1,FALSE,0,0,0,0,0,0,0,0,0,0,0,0,FALSE,FALSE,FALSE,FALSE,0
yikes!