lua_command() dead assignment of 'script_file'

• Relator: cazfi
• Dono: cazfi
• Tipo: Bugs
• Estado: Fechado
• Componente: Server
• Marcos: 3.0.8 (fechado)
• Prioridade: 5 - Medium
• Gravidade: 5 - Medium
• Resolução: Fixed
• Arquivo: 4

Details

../../../src/server/stdinhand.c:5116:13: warning: Although the value stored to 'script_file' is used in the enclosing expression, the value is never actually read from 'script_file' [deadcode.DeadStores]

&& (script_file = fc_fopen(real_filename, "r"))) {

S3_1 and later have two of these as they have loading of two script files implemented the same way.

Ticket History (3/13 Histories)

2023-03-20 15:28 Updated by: cazfi

• New Ticket "lua_command() dead assignment of 'script_file'" created

2023-03-20 18:01 Updated by: cazfi

Comentário

This is real bug - those file descriptors are leaking.

2023-03-22 01:40 Updated by: cazfi

• File 0037-lua_command-Use-fc_stat-instead-of-opening-the-file.patch (File ID: 11920) is attached

2023-03-22 01:40 Updated by: cazfi

• File 0019-lua_command-Use-fc_stat-instead-of-opening-the-file.patch (File ID: 11921) is attached

2023-03-22 01:40 Updated by: cazfi

• Dono Update from (Nenhum) to cazfi
• Resolução Update from Nenhum to Accepted

Comentário

Also to S2_6 - to fix those descriptor leaks.

2023-03-22 10:35 Updated by: cazfi

• Resolução Update from Accepted to Nenhum

Comentário

Check is reversed, I think.

2023-03-22 23:53 Updated by: cazfi

• Marco Update from 3.0.7 (fechado) to 3.0.8 (fechado)

Comentário

Risk / benefit does not look good at this point of 3.0.7 cycle.

2023-03-25 02:53 Updated by: cazfi

• File 0015-lua_command-Use-fc_stat-instead-of-opening-the-file.patch (File ID: 11967) is attached

2023-03-25 02:53 Updated by: cazfi

• File 0006-lua_command-Use-fc_stat-instead-of-opening-the-file.patch (File ID: 11968) is attached

2023-03-25 02:54 Updated by: cazfi

• Resolução Update from Nenhum to Accepted

Comentário

Reply To cazfi

Check is reversed, I think.

Fixed. main/S3_2/S3_1 patch also removes pointless 'goto' from the neighborhood.

2023-03-26 19:39 Updated by: cazfi

Comentário

Reply To cazfi

Risk / benefit does not look good at this point of 3.0.7 cycle.

Can still be pushed to all other branches before 3.0.7 release.

2023-04-02 11:57 Updated by: cazfi

Comentário

Reply To cazfi

Reply To cazfi

Risk / benefit does not look good at this point of 3.0.7 cycle.

Can still be pushed to all other branches before 3.0.7 release.

Have done just that.

2023-04-08 04:44 Updated by: cazfi

• Estado Update from Aberto to Fechado
• Resolução Update from Accepted to Fixed