Player removal not removing city border claims

• Relator: cazfi
• Dono: cazfi
• Tipo: Bugs
• Estado: Fechado
• Componente: Server
• Marcos: 3.0.9 (fechado)
• Prioridade: 5 - Medium
• Gravidade: 5 - Medium
• Resolução: Fixed
• Arquivo: 9

Details

server_remove_player() calls player_clear() in common/ code, and that removes cities by game_remove_city() only, while proper server side city removal would include remove_city() call. This likely has other effects, but I noticed this while debugging why there's a city border claim from already removed player.

Ticket History (3/15 Histories)

2023-10-13 03:51 Updated by: cazfi

• New Ticket "Player removal not removing city border claims" created

2023-10-13 04:08 Updated by: cazfi

• File 0049-Player-removel-Clear-city-border-claims.patch (File ID: 13528) is attached

2023-10-13 04:11 Updated by: cazfi

• File 0010-Player-removel-Clear-city-border-claims.patch (File ID: 13529) is attached

2023-10-13 04:13 Updated by: cazfi

• File 0005-Player-removal-Clear-city-border-claims.patch (File ID: 13530) is attached

2023-10-13 04:13 Updated by: cazfi

• Dono Update from (Nenhum) to cazfi
• Resolução Update from Nenhum to Accepted

Comentário

Patches for all branches, including S2_6, attached.

2023-10-15 03:46 Updated by: cazfi

• Resolução Update from Accepted to Nenhum

Comentário

Currrent patch seems to cause some crashes itself.

2023-10-17 05:37 Updated by: cazfi

• File 0004-Player-removal-Clear-city-border-claims.patch (File ID: 13552) is attached

2023-10-17 05:38 Updated by: cazfi

• File 0008-Player-removal-Clear-city-border-claims.patch (File ID: 13553) is attached

2023-10-17 06:04 Updated by: cazfi

• File 0026-Player-removal-Clear-city-border-claims.patch (File ID: 13554) is attached

2023-10-17 06:05 Updated by: cazfi

• Resolução Update from Nenhum to Accepted

Comentário

Reply To cazfi

Currrent patch seems to cause some crashes itself.

Fixed. Was about accessing nonexistent visions.

2023-10-18 12:03 Updated by: cazfi

• File 0020-Player-removal-Clear-city-border-claims.patch (File ID: 13565) is attached

2023-10-18 12:09 Updated by: cazfi

• File 0006-Player-removal-Clear-city-border-claims.patch (File ID: 13566) is attached

2023-10-18 12:09 Updated by: cazfi

• File 0004-Player-removal-Clear-city-border-claims.patch (File ID: 13567) is attached

2023-10-18 12:23 Updated by: cazfi

Comentário

Reply To cazfi

Reply To cazfi

Currrent patch seems to cause some crashes itself.

Fixed. Was about accessing nonexistent visions.

New versions attached, with one more nonexistent vision issue resolved.

2023-10-25 00:38 Updated by: cazfi

• Estado Update from Aberto to Fechado
• Resolução Update from Accepted to Fixed