[Groonga-commit] groonga/groonga [master] test: simplify the condition part

Back to archive index

null+****@clear***** null+****@clear*****
2012年 5月 16日 (水) 19:53:13 JST


HAYASHI Kentaro	2012-05-16 19:53:13 +0900 (Wed, 16 May 2012)

  New Revision: b775be997613ec4d8aed7ce860f973abe2d812c4

  Log:
    test: simplify the condition part

  Modified files:
    test/function/tools/geo/generate-grntest-data.rb

  Modified: test/function/tools/geo/generate-grntest-data.rb (+44 -16)
===================================================================
--- test/function/tools/geo/generate-grntest-data.rb    2012-05-16 19:13:41 +0900 (5937bda)
+++ test/function/tools/geo/generate-grntest-data.rb    2012-05-16 19:53:13 +0900 (096c62c)
@@ -91,6 +91,46 @@ class GrnTestData
     end
   end
 
+  def east_axis_to_north_axis?
+    east_axis?(@longitude_start_degree, @latitude_start_degree) and
+      north_axis?(@longitude_end_degree, @latitude_end_degree)
+  end
+
+  def north_axis_to_east_axis?
+    north_axis?(@longitude_start_degree, @latitude_start_degree) and
+      east_axis?(@longitude_end_degree, @latitude_end_degree)
+  end
+
+  def north_axis_to_west_axis?
+    north_axis?(@longitude_start_degree, @latitude_start_degree) and
+      west_axis?(@longitude_end_degree, @latitude_end_degree)
+  end
+
+  def west_axis_to_north_axis?
+    west_axis?(@longitude_start_degree, @latitude_start_degree) and
+      north_axis?(@longitude_end_degree, @latitude_end_degree)
+  end
+
+  def west_axis_to_south_axis?
+    west_axis?(@longitude_start_degree, @latitude_start_degree) and
+      south_axis?(@longitude_end_degree, @latitude_end_degree)
+  end
+
+  def south_axis_to_west_axis?
+    south_axis?(@longitude_start_degree, @latitude_start_degree) and
+      west_axis?(@longitude_end_degree, @latitude_end_degree)
+  end
+
+  def east_axis_to_south_axis?
+    east_axis?(@longitude_start_degree, @latitude_start_degree) and
+            south_axis?(@longitude_end_degree, @latitude_end_degree)
+  end
+
+  def south_axis_to_east_axis?
+    south_axis?(@longitude_start_degree, @latitude_start_degree) and
+      east_axis?(@longitude_end_degree, @latitude_end_degree)
+  end
+
   def quadrant_to
     squadrant = quadrant(@longitude_start_degree, @latitude_start_degree)
     equadrant = quadrant(@longitude_end_degree, @latitude_end_degree)
@@ -108,25 +148,13 @@ class GrnTestData
       "equator"
     elsif !squadrant or !equadrant
       if (not squadrant) and (not equadrant)
-        if east_axis?(@longitude_start_degree, @latitude_start_degree) and
-            north_axis?(@longitude_end_degree, @latitude_end_degree) or
-            north_axis?(@longitude_start_degree, @latitude_start_degree) and
-            east_axis?(@longitude_end_degree, @latitude_end_degree)
+        if east_axis_to_north_axis? or north_axis_to_east_axis?
           "1st"
-        elsif north_axis?(@longitude_start_degree, @latitude_start_degree) and
-            west_axis?(@longitude_end_degree, @latitude_end_degree) or
-            west_axis?(@longitude_start_degree, @latitude_start_degree) and
-            north_axis?(@longitude_end_degree, @latitude_end_degree)
+        elsif north_axis_to_west_axis? or west_axis_to_north_axis?
           "2nd"
-        elsif west_axis?(@longitude_start_degree, @latitude_start_degree) and
-            south_axis?(@longitude_end_degree, @latitude_end_degree) or
-            south_axis?(@longitude_start_degree, @latitude_start_degree) and
-            west_axis?(@longitude_end_degree, @latitude_end_degree)
+        elsif west_axis_to_south_axis? or south_axis_to_west_axis?
           "3rd"
-        elsif east_axis?(@longitude_start_degree, @latitude_start_degree) and
-            south_axis?(@longitude_end_degree, @latitude_end_degree) or
-            south_axis?(@longitude_start_degree, @latitude_start_degree) and
-            east_axis?(@longitude_end_degree, @latitude_end_degree)
+        elsif east_axis_to_south_axis? or south_axis_to_east_axis?
           "4th"
         end
       elsif not squadrant




Groonga-commit メーリングリストの案内
Back to archive index