[Groonga-mysql-commit] mroonga/mroonga at 99a8386 [master] storage: fix a bug that table specified index can't be removed

Back to archive index

Kouhei Sutou null+****@clear*****
Fri Aug 22 23:13:10 JST 2014


Kouhei Sutou	2014-08-22 23:13:10 +0900 (Fri, 22 Aug 2014)

  New Revision: 99a8386e77036913909fd83255e5a3579d7c46ba
  https://github.com/mroonga/mroonga/commit/99a8386e77036913909fd83255e5a3579d7c46ba

  Message:
    storage: fix a bug that table specified index can't be removed
    
    You can specify table of index by `COMMENT 'table "XXX"'`.
    
    [groonga-dev,02677]
    
    Reported by Naoya Murakami. Thanks!!!

  Modified files:
    ha_mroonga.cpp

  Modified: ha_mroonga.cpp (+3 -7)
===================================================================
--- ha_mroonga.cpp    2014-08-22 22:24:36 +0900 (22a5111)
+++ ha_mroonga.cpp    2014-08-22 23:13:10 +0900 (8646d74)
@@ -13401,13 +13401,9 @@ bool ha_mroonga::storage_inplace_alter_table_index(
     while (strcmp(key_info[j].name, key->name)) {
       ++j;
     }
-    mrn::IndexTableName index_table_name(mapper.table_name(), key->name);
-    grn_obj *index_table = grn_ctx_get(ctx,
-                                       index_table_name.c_str(),
-                                       index_table_name.length());
-    if (index_table) {
-      grn_obj_remove(ctx, index_table);
-    }
+    error = drop_index(share, j);
+    if (error)
+      DBUG_RETURN(true);
     grn_index_tables[j] = NULL;
     grn_index_columns[j] = NULL;
   }
-------------- next part --------------
HTML����������������������������...
Download 



More information about the Groonga-mysql-commit mailing list
Back to archive index