Thanks for reviewing! On 2020-02-25 15:46, Fujii Masao wrote: > Or what about just reporting "pgs2malloc()" for > the consistency with the detailed information of log? That sounds appropriate for this situation. > Your patch seems to forget to treat the following log message. > > elog(LOG, "GetSennaQuery(): quick exit: %s", tmp); Oops, I've added 'terse' condition to GetSennaQuery(). > I think that it's better to comment the reason why 'terse' is enough > for this regression test. So I'd like to add something like the > following > comments based on the comments that you added. Thought? Thanks for rewriting the comments! It seems much better than mine. Attached an updated patch. Regards, Torikoshi Atsushi -------------- next part -------------- テキスト形式以外の添付ファイルを保管しました... ファイル名: enable_debug_to_terse_v3.patch 型: text/x-diff サイズ: 13382 バイト 説明: 無し URL: <https://lists.osdn.me/mailman/archives/ludiafuncs-hackers/attachments/20200226/b038fccd/attachment.patch>
Fork