kimura wataru
kimur****@i*****
Fri Jun 2 01:15:52 JST 2006
Hi, I tried this branch and found a small bug. === framework/src/objc/mdl_objwrapper.m ================================================================== --- framework/src/objc/mdl_objwrapper.m (revision 127) +++ framework/src/objc/mdl_objwrapper.m (local) @@ -356,7 +356,7 @@ // Retain if necessary the returned ObjC value unless it was generated by "alloc/allocWithZone/new/copy/mutableCopy". if (result != NULL && *result != Qnil && rb_obj_is_kind_of(*result, objid_s_class()) == Qtrue) { if (strcmp((const char *)ctx->selector, "alloc") != 0 - && strcmp((const char *)ctx->selector, "allocWithZone") != 0 + && strcmp((const char *)ctx->selector, "allocWithZone:") != 0 && strcmp((const char *)ctx->selector, "new") != 0 && strcmp((const char *)ctx->selector, "copy") != 0 && strcmp((const char *)ctx->selector, "mutableCopy") != 0 === tests/tc_retaincount.rb ================================================================== --- tests/tc_retaincount.rb (revision 127) +++ tests/tc_retaincount.rb (local) @@ -14,8 +14,7 @@ # retained by Ruby def test_rb_rbclass assert_equal(1, RBSubclass.alloc.retainCount, 'alloc') -# FIXME -# assert_equal(1, RBSubclass.allocWithZone(nil).retainCount, 'allocWithZone:') + assert_equal(1, RBSubclass.allocWithZone(nil).retainCount, 'allocWithZone:') assert_equal(1, RBSubclass.alloc.init.retainCount, 'alloc.init') end On Tue, 30 May 2006 18:35:30 +0200, Laurent Sansonetti wrote: > Hi all, > > I just created a new branch on CVS called 'apple-unstable' and > committed some new changes there! Please check it out and tell me > what you think about them (that are described at the top of the > ChangeLog file). > -- kimura wataru