Commit: 340f3ac8082771ecc473ab938fc3d7cbf607ddaa - binutils_os216 (git)

GNU Binutils with patches for OS216

Commit MetaInfo

• Revisão: 340f3ac8082771ecc473ab938fc3d7cbf607ddaa (tree)
• Hora: 2020-03-20 11:05:51
• Autor: Alan Modra <amodra@gmai...>
• Commiter: Alan Modra

Mensagem de Log

metag uninitialized memory read

* metag-dis.c (print_insn_metag): Don't ignore status from
read_memory_func.

Mudança Sumário

• modified: opcodes/ChangeLog
• modified: opcodes/metag-dis.c

Diff

--- a/opcodes/ChangeLog
+++ b/opcodes/ChangeLog
@@ -1,5 +1,10 @@
 2020-03-20  Alan Modra  <[e-mail]>
 
+	* metag-dis.c (print_insn_metag): Don't ignore status from
+	read_memory_func.
+
[phone]  Alan Modra  <[e-mail]>
+
 	* nds32-dis.c (print_insn_nds32): Remove unnecessary casts.
 	Initialize parts of buffer not written when handling a possible
 	2-byte insn at end of section.  Don't attempt decoding of such

--- a/opcodes/metag-dis.c
+++ b/opcodes/metag-dis.c
@@ -3364,9 +3364,15 @@ print_insn_metag (bfd_vma pc, disassemble_info *outf)
   bfd_byte buf[4];
   unsigned int insn_word;
   size_t i;
-  outf->bytes_per_chunk = 4;
+  int status;
 
-  (*outf->read_memory_func) (pc & ~0x03, buf, 4, outf);
+  outf->bytes_per_chunk = 4;
+  status = (*outf->read_memory_func) (pc & ~0x03, buf, 4, outf);
+  if (status)
+    {
+      (*outf->memory_error_func) (status, pc, outf);
+      return -1;
+    }
   insn_word = bfd_getl32 (buf);
 
   for (i = 0; i < sizeof(metag_optab)/sizeof(metag_optab[0]); i++)