Commit: 586b02a96f744497c8921a558f1c386287849ab0 - binutils_os216 (git)

GNU Binutils with patches for OS216

Commit MetaInfo

• Revisão: 586b02a96f744497c8921a558f1c386287849ab0 (tree)
• Hora: 2015-07-14 18:10:50
• Autor: Pedro Alves <palves@redh...>
• Commiter: Pedro Alves

Mensagem de Log

gdbserver/Linux: internal error when killing a process that is already gone

If the process disappears (e.g., killed with "kill -9" from the shell)
while it was stopped under GDBserver's control, and the GDBserver
tries to kill it, GDBserver asserts:

(gdb) shell kill -9 23084
(gdb) kill
...
Killing process(es): 23084
/home/pedro/gdb/mygit/src/gdb/gdbserver/linux-low.c:972: A problem internal to GDBserver has been detected.
kill_wait_lwp: Assertion res > 0' failed.
...

gdb/gdbserver/ChangeLog:
2015-07-14 Pedro Alves <[e-mail]>

* linux-low.c (kill_wait_lwp): Don't assert if waitpid fails.
Instead, ignore ECHILD, and throw an error for other errnos.

Mudança Sumário

• modified: gdb/gdbserver/ChangeLog
• modified: gdb/gdbserver/linux-low.c

Diff

--- a/gdb/gdbserver/ChangeLog
+++ b/gdb/gdbserver/ChangeLog
@@ -1,3 +1,8 @@
[phone]  Pedro Alves  <[e-mail]>
+
+	* linux-low.c (kill_wait_lwp): Don't assert if waitpid fails.
+	Instead, ignore ECHILD, and throw an error for other errnos.
+
 2015-07-10  Pedro Alves  <[e-mail]>
 
 	* event-loop.c (struct callback_event) <data>: Change type to

--- a/gdb/gdbserver/linux-low.c
+++ b/gdb/gdbserver/linux-low.c
@@ -1103,7 +1103,10 @@ kill_wait_lwp (struct lwp_info *lwp)
 	res = my_waitpid (lwpid, &wstat, __WCLONE);
     } while (res > 0 && WIFSTOPPED (wstat));
 
-  gdb_assert (res > 0);
+  /* Even if it was stopped, the child may have already disappeared.
+     E.g., if it was killed by SIGKILL.  */
+  if (res < 0 && errno != ECHILD)
+    perror_with_name ("kill_wait_lwp");
 }
 
 /* Callback for `find_inferior'.  Kills an lwp of a given process,