Commit: 25f4891078d548376a40b90fb1ef401304008e4f - zandronum-macos (hg)

This is a fork of Zandronum for Mac Os (Silicon and Intel)

Commit MetaInfo

• Revisão: 25f4891078d548376a40b90fb1ef401304008e4f (tree)
• Hora: 2007-10-12 12:26:28
• Autor: Brad Carney <bmc431@gmai...>
• Commiter: Brad Carney

Mensagem de Log

- Fixed vulnerability that allowed clients to crash all other clients by saying a chat string with "%n".

SVN r836 (beta4-2_b)

Mudança Sumário

• modified: docs/Skulltag Version History.txt
• modified: src/botcommands.cpp
• modified: src/version.h

Diff

diff -r 16cc7cc04634 -r 25f4891078d5 docs/Skulltag Version History.txt
--- a/docs/Skulltag Version History.txt	Wed Sep 26 02:53:18 2007 +0000
+++ b/docs/Skulltag Version History.txt	Fri Oct 12 03:26:28 2007 +0000
@@ -11,6 +11,11 @@
 = 
 ===============================================================================================================
 
+v0.97d-beta4.3
+--------------
+
+*- 	- Fixed vulnerability that allowed clients to crash all other clients by saying a chat string with "%n". [Carnevil]
+
 v0.97d-beta4.2
 --------------
 

diff -r 16cc7cc04634 -r 25f4891078d5 src/botcommands.cpp
--- a/src/botcommands.cpp	Wed Sep 26 02:53:18 2007 +0000
+++ b/src/botcommands.cpp	Fri Oct 12 03:26:28 2007 +0000
@@ -599,14 +599,16 @@
 //
 void BOTCMD_SetLastChatString( char *pszString )
 {
-	sprintf( g_szLastChatString, pszString );
+	strncpy( g_szLastChatString, pszString, 255 );
+	g_szLastChatString[255] = 0;
 }
 
 //*****************************************************************************
 //
 void BOTCMD_SetLastChatPlayer( char *pszString )
 {
-	sprintf( g_szLastChatPlayer, pszString );
+	strncpy( g_szLastChatPlayer, pszString, 255 );
+	g_szLastChatPlayer[255] = 0;
 }
 
 //*****************************************************************************

diff -r 16cc7cc04634 -r 25f4891078d5 src/version.h
--- a/src/version.h	Wed Sep 26 02:53:18 2007 +0000
+++ b/src/version.h	Fri Oct 12 03:26:28 2007 +0000
@@ -40,7 +40,7 @@
 
 /** Lots of different version numbers **/
 
-#define DOTVERSIONSTR "0.97d-beta4.2"
+#define DOTVERSIONSTR "0.97d-beta4.3"
 
 // [BB] Define DOTVERSIONSTR_NOREV to stay compatible with IWADBoxCallback in I_system.cpp
 #define DOTVERSIONSTR_NOREV DOTVERSIONSTR
@@ -64,7 +64,8 @@
 // NETGAMEVERSION 004 = 0.97c3
 // NETGAMEVERSION 005 = 0.97d-beta4
 // NETGAMEVERSION 006 = 0.97d-beta4.2
-#define NETGAMEVERSION 006
+// NETGAMEVERSION 007 = 0.97d-beta4.3
+#define NETGAMEVERSION 007
 
 // Version stored in the ini's [LastRun] section.
 // Bump it if you made some configuration change that you want to