Commit: 2e55ec2a45650ddeb443c249c99f142d082d9d83 - system-core (git)

system/core

Commit MetaInfo

• Revisão: 2e55ec2a45650ddeb443c249c99f142d082d9d83 (tree)
• Hora: 2017-11-14 10:30:10
• Autor: tintin <tintinweb@osts...>
• Commiter: Nikoli Cartagena

Mensagem de Log

libnetutil: Check dhcp respose packet length

Bug: 67474440
Test: Manual

Change-Id: I84b533f0101a56ec01e64c7591f3c7e82f513b2e
Signed-off-by: Dmitry Shmidt <[e-mail]>
(cherry picked from commit 61f25d4a3657e79659963d12005afa8c30883015)

Mudança Sumário

• modified: libnetutils/packet.c

Diff

--- a/libnetutils/packet.c
+++ b/libnetutils/packet.c
@@ -219,6 +219,20 @@ int receive_packet(int s, struct dhcp_msg *msg)
      * to construct the pseudo header used in the checksum calculation.
      */
     dhcp_size = ntohs(packet.udp.len) - sizeof(packet.udp);
+    /*
+     * check validity of dhcp_size.
+     * 1) cannot be negative or zero.
+     * 2) src buffer contains enough bytes to copy
+     * 3) cannot exceed destination buffer
+     */
+    if ((dhcp_size <= 0) ||
+        ((int)(nread - sizeof(struct iphdr) - sizeof(struct udphdr)) < dhcp_size) ||
+        ((int)sizeof(struct dhcp_msg) < dhcp_size)) {
+#if VERBOSE
+        ALOGD("Malformed Packet");
+#endif
+        return -1;
+    }
     saddr = packet.ip.saddr;
     daddr = packet.ip.daddr;
     nread = ntohs(packet.ip.tot_len);