[Freeciv-tickets] [freeciv] #42704: civ2civ3: patches compatible with 2.6

Back to archive index
OSDN Ticket System norep****@osdn*****
Sun Sep 5 18:53:07 JST 2021


#42704: civ2civ3: patches compatible with 2.6

  Open Date: 2021-08-10 23:37
Last Update: 2021-09-05 12:53

URL for this Ticket:
    https://osdn.net//projects/freeciv/ticket/42704
RSS feed for this Ticket:
    https://osdn.net/ticket/ticket_rss.php?group_id=12505&tid=42704

---------------------------------------------------------------------

Last Changes/Comment on this Ticket:
2021-09-05 12:53 Updated by: cazfi

Comment:

Reply To bard

If I create a new helptext, which format is preferred:
1) space at the end of the line 2) or space at the start of the new line
There's no clear consensus about that, so I think either is acceptable at this time.
 I recently (civ2civ3 v2.6) introduced by mistake some more tabs in all the building effects related to culture
I was going to make a patch to change them from tabs to spaces again. Would it be ok? Should I change all tabs to spaces in the effects.ruleset file (including those related to diplomacy and agent actions), or only the ones introduced by me in civ2civ3 (so the diplomacy section keeps the same format in all rulesets)? Or I better keep all tabs/spaces unchanged?
Either change just those tabs to spaces (so that civ2civ3 effects.ruleset has equivalent format to other effects.rulesets) or change all tabs in all effects.rulesets. I don't think the middle-ground of changing all tabs in just civ2civ3 effects.ruleset would be a good idea.

---------------------------------------------------------------------
Ticket Status:

      Reporter: bard
         Owner: (None)
          Type: Tasks
        Status: Open
      Priority: 5 - Medium
     MileStone: (None)
     Component: Rulesets
      Severity: 5 - Medium
    Resolution: None
---------------------------------------------------------------------

Ticket details:

This ticket will join in one place the patches for civ2civ3 made by me that are compatible with v2.6, and I expect to be included in future v3.1
I'll make the patch for S2_6 only if it is a bug fix (none planned for now). And I'll make the patch for S3_0 if I think most people would consider it an improvement and there is low risk of breaking anything.
Now that I'm on vacation, I hope I can finally finish the patches I had planned.

-- 
Ticket information of Freeciv project
Freeciv Project is hosted on OSDN

Project URL: https://osdn.net/projects/freeciv/
OSDN: https://osdn.net

URL for this Ticket:
    https://osdn.net/projects/freeciv/ticket/42704
RSS feed for this Ticket:
    https://osdn.net/ticket/ticket_rss.php?group_id=12505&tid=42704



More information about the Freeciv-tickets mailing list
Back to archive index