#45488: City celebrated counter
Open Date: 2022-08-28 02:07
Last Update: 2022-12-01 05:41
URL for this Ticket:
https://osdn.net//projects/freeciv/ticket/45488
RSS feed for this Ticket:
https://osdn.net/ticket/ticket_rss.php?group_id=12505&tid=45488
---------------------------------------------------------------------
Last Changes/Comment on this Ticket:
2022-12-01 05:41 Updated by: cazfi
Comment:
With this patch you are checking if the city is happy, not if it's celebrating. Former can lead to latter, but it's not the same thing.
I would put the counter increase inside update_city_activity() where the server determines if the city celebrates this turn - there's already a "if () {} else {}" -blocks there for sending notifications about celebration. Having all the counter updates in one place would have its benefits, but that's going to be impossible with some counter anyway (anything that's being updated more frequently than once a turn)
---------------------------------------------------------------------
Ticket Status:
Reporter: cazfi
Owner: (None)
Type: Patches
Status: Open
Priority: 5 - Medium
MileStone: S3_2 d3f
Component: General
Severity: 5 - Medium
Resolution: None
---------------------------------------------------------------------
Ticket details:
Add counter_behavior "Celebrated" - increased if city celebrates at turn change, otherwise zeroed.
--
Ticket information of Freeciv project
Freeciv Project is hosted on OSDN
Project URL: https://osdn.net/projects/freeciv/
OSDN: https://osdn.net
URL for this Ticket:
https://osdn.net/projects/freeciv/ticket/45488
RSS feed for this Ticket:
https://osdn.net/ticket/ticket_rss.php?group_id=12505&tid=45488