#46202: effect_edit::comment_given() not setting empty comment Open Date: 2022-12-05 10:35 Last Update: 2022-12-05 16:44 URL for this Ticket: https://osdn.net//projects/freeciv/ticket/46202 RSS feed for this Ticket: https://osdn.net/ticket/ticket_rss.php?group_id=12505&tid=46202 --------------------------------------------------------------------- Last Changes/Comment on this Ticket: 2022-12-05 16:44 Updated by: cazfi * Owner Update from (None) to cazfi * Resolution Update from None to Accepted --------------------------------------------------------------------- Ticket Status: Reporter: cazfi Owner: cazfi Type: Bugs Status: Open [Owner assigned] Priority: 5 - Medium MileStone: 3.2.0 Component: Ruledit and ruleup Severity: 5 - Medium Resolution: Accepted --------------------------------------------------------------------- Ticket details: In case of empty comment from the user input, effect_edit::comment_given() frees the existing comment, but leaves the pointer. effect_edit::fill_active() then uses it. -- Ticket information of Freeciv project Freeciv Project is hosted on OSDN Project URL: https://osdn.net/projects/freeciv/ OSDN: https://osdn.net URL for this Ticket: https://osdn.net/projects/freeciv/ticket/46202 RSS feed for this Ticket: https://osdn.net/ticket/ticket_rss.php?group_id=12505&tid=46202