#45489: City disorder counter
Open Date: 2022-08-28 02:08
Last Update: 2022-12-11 04:08
URL for this Ticket:
https://osdn.net//projects/freeciv/ticket/45489
RSS feed for this Ticket:
https://osdn.net/ticket/ticket_rss.php?group_id=12505&tid=45489
---------------------------------------------------------------------
Last Changes/Comment on this Ticket:
2022-12-11 04:08 Updated by: cazfi
Comment:
Reply To lachu
Ok. I see this patch did not apply on master. I download freeciv source code, create new branch from master and try to apply. fc_types.h do not have counter celebrates patch applied. Should I provide changes based on master, so there could been problems apply this patch, if you apply city's celebrating patch? Or just leave it as it is. I am not 100% sure if I am rebase it on master, it would not apply if celebration was applied. Git tracks commit history (for each patch stores parent patch, so maybe it will be solved automatically?). I am beginner in programing, who develop single-person projects for many years.
Whether patch applies depends mostly if the context of the changes is there or not. Can't replace code that is not there to begin with. You can look at the patch file to see what is expects to find as the "original code" (any lines it wants to remove, and any lines it's not going to touch but still lists as the context of the changed lines)
If your patch depends on another one, either logically or textually (it wouldn't apply), you should just mention that dependency while submitting it.
---------------------------------------------------------------------
Ticket Status:
Reporter: cazfi
Owner: (None)
Type: Patches
Status: Open
Priority: 5 - Medium
MileStone: S3_2 d3f
Component: General
Severity: 5 - Medium
Resolution: None
---------------------------------------------------------------------
Ticket details:
Add counter_behavior "Disorder" - increased if city is in disorder at turn change, otherwise zeroed.
--
Ticket information of Freeciv project
Freeciv Project is hosted on OSDN
Project URL: https://osdn.net/projects/freeciv/
OSDN: https://osdn.net
URL for this Ticket:
https://osdn.net/projects/freeciv/ticket/45489
RSS feed for this Ticket:
https://osdn.net/ticket/ticket_rss.php?group_id=12505&tid=45489