#43938: generate_packets.py: Make internal parameters argparse-controllable Open Date: 2022-02-20 04:42 Last Update: 2022-02-25 04:45 URL for this Ticket: https://osdn.net//projects/freeciv/ticket/43938 RSS feed for this Ticket: https://osdn.net/ticket/ticket_rss.php?group_id=12505&tid=43938 --------------------------------------------------------------------- Last Changes/Comment on this Ticket: 2022-02-25 04:45 Updated by: cazfi Comment: Reply To alienvalkyrie As mentioned above; this patch exposes options with no regard for whether they actually work – the -s, --gen-stats option does not (#43979) This patch makes the situation worse in that you expose the crash, and make the code in question more officially supported. Before it was not crashing unless you modified the code. Resolve #43979 first. --------------------------------------------------------------------- Ticket Status: Reporter: alienvalkyrie Owner: alienvalkyrie Type: Patches Status: Open [Owner assigned] Priority: 5 - Medium MileStone: 3.2.0 Component: Bootstrap Severity: 5 - Medium Resolution: Accepted --------------------------------------------------------------------- Ticket details: Follow-up to #43931. Part of #43927. There are currently a number of internal parameters (generate_stats, generate_logs/use_log_macro, fold_bool_into_header and lazy_overwrite) that are set in the code. They should be set depending on optional command line arguments instead. -- Ticket information of Freeciv project Freeciv Project is hosted on OSDN Project URL: https://osdn.net/projects/freeciv/ OSDN: https://osdn.net URL for this Ticket: https://osdn.net/projects/freeciv/ticket/43938 RSS feed for this Ticket: https://osdn.net/ticket/ticket_rss.php?group_id=12505&tid=43938