#44759: diplstate max_state not set on first contact Open Date: 2022-06-06 04:26 Last Update: 2022-06-12 03:22 URL for this Ticket: https://osdn.net//projects/freeciv/ticket/44759 RSS feed for this Ticket: https://osdn.net/ticket/ticket_rss.php?group_id=12505&tid=44759 --------------------------------------------------------------------- Last Changes/Comment on this Ticket: 2022-06-12 03:22 Updated by: cazfi * Owner Update from (None) to cazfi * Resolution Update from None to Accepted Comment: Will push S3_0 patch to S2_6 too --------------------------------------------------------------------- Ticket Status: Reporter: cazfi Owner: cazfi Type: Bugs Status: Open [Owner assigned] Priority: 5 - Medium MileStone: 3.0.3 Component: Server Severity: 5 - Medium Resolution: Accepted --------------------------------------------------------------------- Ticket details: First of the problems seen when trying to work on #44732 is that max_state is not set on first contact. Fixing that one seems relatively low-risk (unlikely that anything depends on max_state being "Never met" when players have actually already met). There are other cases where max_state is not updated, where fixing seems more risky (maybe some place relies on max_state not being transitional state such as "Cease-Fire" or "Armistice" - especially if that transition never finished) -- Ticket information of Freeciv project Freeciv Project is hosted on OSDN Project URL: https://osdn.net/projects/freeciv/ OSDN: https://osdn.net URL for this Ticket: https://osdn.net/projects/freeciv/ticket/44759 RSS feed for this Ticket: https://osdn.net/ticket/ticket_rss.php?group_id=12505&tid=44759