#44495: create_command_newcomer() may break if there's no dead players
Open Date: 2022-05-02 02:13
Last Update: 2022-05-12 03:43
URL for this Ticket:
https://osdn.net//projects/freeciv/ticket/44495
RSS feed for this Ticket:
https://osdn.net/ticket/ticket_rss.php?group_id=12505&tid=44495
---------------------------------------------------------------------
Last Changes/Comment on this Ticket:
2022-05-12 03:43 Updated by: cazfi
Comment:
Reply To cazfi
Will push even to S2_6
No, I won't. This introduces a new string, and we don't assume translators to touch S2_6 any more.
---------------------------------------------------------------------
Ticket Status:
Reporter: cazfi
Owner: cazfi
Type: Bugs
Status: Open [Owner assigned]
Priority: 5 - Medium
MileStone: 3.0.2
Component: Server
Severity: 5 - Medium
Resolution: Accepted
---------------------------------------------------------------------
Ticket details:
create_command_newcomer() may try to free player slot for the new player by removing dead player(s). This works correctly only when there's exactly one dead player. If there's none -> it still continues as if it now would have a free slot. If there's more than one -> the message about "replacing dead player" has a wrong name (last of the freed dead players, while it will replace the first one).
--
Ticket information of Freeciv project
Freeciv Project is hosted on OSDN
Project URL: https://osdn.net/projects/freeciv/
OSDN: https://osdn.net
URL for this Ticket:
https://osdn.net/projects/freeciv/ticket/44495
RSS feed for this Ticket:
https://osdn.net/ticket/ticket_rss.php?group_id=12505&tid=44495