#44185: create_command_newcomer() may unconditionally increase maxplayers
Open Date: 2022-03-25 20:38
Last Update: 2022-05-12 12:15
URL for this Ticket:
https://osdn.net//projects/freeciv/ticket/44185
RSS feed for this Ticket:
https://osdn.net/ticket/ticket_rss.php?group_id=12505&tid=44185
---------------------------------------------------------------------
Last Changes/Comment on this Ticket:
2022-05-12 12:15 Updated by: cazfi
Comment:
Depends on #44567
---------------------------------------------------------------------
Ticket Status:
Reporter: cazfi
Owner: (None)
Type: Bugs
Status: Open
Priority: 7
MileStone: 3.0.2
Component: Server
Severity: 5 - Medium
Resolution: None
---------------------------------------------------------------------
Ticket details:
If there is already maxplayers players, create_command_newcomer() just increases maxplayers setting and proceeds to create the player. That seems VERY wrong. The command should fail, not override limitation set by the server operator (what is the point of the setting if it's not respected?)
I note that help for 'maxplayer' setting does match this by explicitly saying "...in pregame...", but that doesn't make any more sane behavior.
--
Ticket information of Freeciv project
Freeciv Project is hosted on OSDN
Project URL: https://osdn.net/projects/freeciv/
OSDN: https://osdn.net
URL for this Ticket:
https://osdn.net/projects/freeciv/ticket/44185
RSS feed for this Ticket:
https://osdn.net/ticket/ticket_rss.php?group_id=12505&tid=44185