#44591: Savegame conversion for irrigation/cultivate & mine/plant from 2.6 broken
Open Date: 2022-05-14 15:21
Last Update: 2022-05-15 04:35
URL for this Ticket:
https://osdn.net//projects/freeciv/ticket/44591
RSS feed for this Ticket:
https://osdn.net/ticket/ticket_rss.php?group_id=12505&tid=44591
---------------------------------------------------------------------
Last Changes/Comment on this Ticket:
2022-05-15 04:35 Updated by: cazfi
* Milestone Update from (None) to 3.1.0
* Component Update from (None) to General
Comment:
This is due to next_extra_for_tile() -> can_build_extra() not checking if irrigation_time/mining_time for the terrain is zero to disable extra building. Thus they propose converting some activities to extra building ones (they think they find suitable extra target) when they should not.
Fix should consider multi-cause extras, i.e., we should not simply add checks similar to existing road_time/base_time checks in can_build_extra() - I think those are already wrong.
---------------------------------------------------------------------
Ticket Status:
Reporter: cazfi
Owner: (None)
Type: Bugs
Status: Open
Priority: 5 - Medium
MileStone: 3.1.0
Component: General
Severity: 5 - Medium
Resolution: None
---------------------------------------------------------------------
Ticket details:
Loading savegame from #44419 to master produces errors. The savegame has been saved from 2.6.5.
Looks like a problem in terrain transforming irrigate / mine conversion to cultivate / plant.
1: Unit doing illegal activity in savegame!
1: Activity: Mine, Target: Mine
and
1: Unit doing illegal activity in savegame!
1: Activity: Irrigate, Target: Irrigation
--
Ticket information of Freeciv project
Freeciv Project is hosted on OSDN
Project URL: https://osdn.net/projects/freeciv/
OSDN: https://osdn.net
URL for this Ticket:
https://osdn.net/projects/freeciv/ticket/44591
RSS feed for this Ticket:
https://osdn.net/ticket/ticket_rss.php?group_id=12505&tid=44591