#44615: generate_packets.py: Add type annotations
Open Date: 2022-05-15 17:33
Last Update: 2022-05-29 21:44
URL for this Ticket:
https://osdn.net//projects/freeciv/ticket/44615
RSS feed for this Ticket:
https://osdn.net/ticket/ticket_rss.php?group_id=12505&tid=44615
---------------------------------------------------------------------
Last Changes/Comment on this Ticket:
2022-05-29 21:44 Updated by: cazfi
Comment:
Reply To alienvalkyrie
we do decide to raise the minimum Python version
One option I have in mind is to start keeping our minimum python version, even for things outside meson build, in line with the minimum python version of our minimum meson version, starting from freeciv-3.3, i.e., in master as soon as S3_2 has been branched.
---------------------------------------------------------------------
Ticket Status:
Reporter: alienvalkyrie
Owner: alienvalkyrie
Type: Patches
Status: Open [Owner assigned]
Priority: 5 - Medium
MileStone: 3.2.0
Component: Bootstrap
Severity: 5 - Medium
Resolution: None
---------------------------------------------------------------------
Ticket details:
Part of #43927. Add PEP 484-style type annotations for use with IDEs and static type checkers.
Problem: Python 3.4 has no special support for type annotations, beyond allowing function argument and return type annotations. In particular, the typing module is only introduced in Python 3.5, and variable annotations only in Python 3.6.
Potential solutions:
Leave out any annotations that would require typing
In particular, this means no generic functions (which some helper functions could be)
Add workaround code to use typing only when available, while maintaining 3.4 compatibility
This might add a certain amount of noise to the script
Increase the minimum supported Python version to 3.5 or even 3.6
The first of these options is likely the best one that doesn't require changing dependency versions.
--
Ticket information of Freeciv project
Freeciv Project is hosted on OSDN
Project URL: https://osdn.net/projects/freeciv/
OSDN: https://osdn.net
URL for this Ticket:
https://osdn.net/projects/freeciv/ticket/44615
RSS feed for this Ticket:
https://osdn.net/ticket/ticket_rss.php?group_id=12505&tid=44615