#45537: "section_list_destroy(sec);" with garbage 'sec'
Open Date: 2022-08-31 18:32
Last Update: 2022-10-02 07:25
URL for this Ticket:
https://osdn.net//projects/freeciv/ticket/45537
RSS feed for this Ticket:
https://osdn.net/ticket/ticket_rss.php?group_id=12505&tid=45537
---------------------------------------------------------------------
Last Changes/Comment on this Ticket:
2022-10-02 07:25 Updated by: cazfi
* Status Update from Open to Closed
* Resolution Update from Accepted to Fixed
---------------------------------------------------------------------
Ticket Status:
Reporter: cazfi
Owner: cazfi
Type: Bugs
Status: Closed
Priority: 5 - Medium
MileStone: 3.0.4
Component: Server
Severity: 5 - Medium
Resolution: Fixed
---------------------------------------------------------------------
Ticket details:
From clang analyzer report from S3_0.
load_ruleset_nations() does not set 'sec' if there's issues detected in earlier part of the function (it gets set only within later "if (ok) {" -block). Regardless, in the cleanup phase there's an assumption that if it's not NULL, it's leftover from abort within the block that uses it.
/* Clean up on aborted load */
if (sec) {
fc_assert(!ok);
section_list_destroy(sec);
}
--
Ticket information of Freeciv project
Freeciv Project is hosted on OSDN
Project URL: https://osdn.net/projects/freeciv/
OSDN: https://osdn.net
URL for this Ticket:
https://osdn.net/projects/freeciv/ticket/45537
RSS feed for this Ticket:
https://osdn.net/ticket/ticket_rss.php?group_id=12505&tid=45537