[Freeciv-tickets] [freeciv] #45907: Add continent control for "CityTile" req

Back to archive index
OSDN Ticket System norep****@osdn*****
Thu Oct 20 06:54:53 JST 2022


#45907: Add continent control for "CityTile" req

  Open Date: 2022-10-17 19:05
Last Update: 2022-10-20 00:54

URL for this Ticket:
    https://osdn.net//projects/freeciv/ticket/45907
RSS feed for this Ticket:
    https://osdn.net/ticket/ticket_rss.php?group_id=12505&tid=45907

---------------------------------------------------------------------

Last Changes/Comment on this Ticket:
2022-10-20 00:54 Updated by: cazfi

Comment:

Did you consider the possibility of the city itself being on ocean tile? Code looks suspicious in that respect, but I didn't think very hard what it would actually do.
--
+      case CITYT_LAST:
+        /* Invalid */
+        return FALSE;
Likely want 'fc_assert(req->source.value.citytile != CITYT_LAST);' here.
--
+    case CITYT_NEAR_SAME_OCEAN:
+        fc_strlcat(buf, _("Tile connected by a body of water"), bufsz);
+        break;
Indendation is off (in the patch, no idea what osdn formatting will do...)

---------------------------------------------------------------------
Ticket Status:

      Reporter: ihnatus
         Owner: (None)
          Type: Feature Requests
        Status: Open
      Priority: 5 - Medium
     MileStone: S3_2 d3f
     Component: General
      Severity: 5 - Medium
    Resolution: None
---------------------------------------------------------------------

Ticket details:

"SameContinent" if the tile is on the same continent as city center, and possibly "NearSameOcean" if tile adjacency shares a negative continent number with city center adjacency. May be used in tile output effects, unit bribe cost effect, and possibly in the future for increasing airport trade bonus for intercontinental trade (civ2).

-- 
Ticket information of Freeciv project
Freeciv Project is hosted on OSDN

Project URL: https://osdn.net/projects/freeciv/
OSDN: https://osdn.net

URL for this Ticket:
    https://osdn.net/projects/freeciv/ticket/45907
RSS feed for this Ticket:
    https://osdn.net/ticket/ticket_rss.php?group_id=12505&tid=45907



More information about the Freeciv-tickets mailing list
Back to archive index