effect_action_success_* coding style

• Relator: cazfi
• Dono: cazfi
• Tipo: Patches
• Estado: Fechado
• Componente: Rulesets
• Marcos: 3.1.0 (fechado)
• Prioridade: 5 - Medium
• Gravidade: 5 - Medium
• Resolução: Fixed
• Arquivo: 1

Details Responder

Noticed in classic/effects.ruleset that new effect_action_success_* effect sections have different coding style to rest of the ruleset (I've had it in my TODO to improve the style in general, but this is especially bad). Is it copied from an update generated by ruleup?

Ticket History (3/9 Histories)

2021-03-13 18:15 Updated by: cazfi

• New Ticket "effect_action_success_* coding style" created

2021-03-13 20:03 Updated by: cazfi

• File 0026-Improve-Action_Success_Actor_Move_Cost-effect-entrie.patch (File ID: 6248) is attached

2021-03-13 20:04 Updated by: cazfi

• Marco Update from (Nenhum) to 3.1.0 (fechado)

2021-03-13 20:08 Updated by: kvilhaugsvik

• Marco Update from 3.1.0 (fechado) to (Nenhum)

Comentário Responder

Reply To cazfi

Is it copied from an update generated by ruleup?

Probably. I typically begin by copying from ruleup, then I fix the coding style (and try to catch redundant rules). I must have forgotten to fix the coding style in this case.

(Edited, 2021-03-13 20:18 Updated by: kvilhaugsvik)

2021-03-15 06:29 Updated by: cazfi

• Resolução Update from Nenhum to Accepted
• Marco Update from (Nenhum) to 3.1.0 (fechado)

Comentário Responder

Seems that it's possible in osdn to accidentally drop properties set by someone else when commenting, if they have been set since your last page reload.

This has been in review since the patch was uploaded.

2021-03-15 15:58 Updated by: cazfi

• Estado Update from Aberto to Fechado
• Resolução Update from Accepted to Fixed

2021-03-15 18:34 Updated by: kvilhaugsvik

Comentário Responder

Did you forget to push to master? Didn't master have this problem?

2021-03-15 18:38 Updated by: cazfi

Comentário Responder

Reply To kvilhaugsvik

Did you forget to push to master? Didn't master have this problem?

I think I did .... and ... CI has build result of it, so seems like it has received it.

2021-03-15 18:43 Updated by: kvilhaugsvik

Comentário Responder

I must have been looking at an old git log. It is here now. Sorry about the noise.

(Edited, 2021-03-15 18:43 Updated by: kvilhaugsvik)