OSX randseed.c compilation failing

• Relator: cazfi
• Dono: cazfi
• Tipo: Bugs
• Estado: Fechado
• Componente: Bootstrap
• Marcos: 2.6.5 (fechado)
• Prioridade: 5 - Medium
• Gravidade: 5 - Medium
• Resolução: Fixed
• Arquivo: 1

Details

Seen on CI, OSX build fails:

--

../../utility/randseed.c:60:7: error: implicit declaration of function 'getentropy' is invalid in C99 -Werror,-Wimplicit-function-declaration

if (getentropy(&seed, sizeof(seed)) == 0) {

--

Configure check for both sys/random.h header and getentropy() existence success. The likely cause of the failure is that AC_CHECK_HEADER() does not, unlike AC_CHECK_HEADERS(), define the HAVE_xxx macro by itself.

Ticket History (3/5 Histories)

2021-04-14 19:33 Updated by: cazfi

• New Ticket "OSX randseed.c compilation failing" created

2021-04-14 19:56 Updated by: cazfi

Comentário

Check for bcrypt.h has been similarly changed from being part of AC_CHECK_HEADERS() to AC_CHECK_HEADER() and macro HAVE_BCRYPT_H is expected in randseed.c.

2021-04-14 20:07 Updated by: cazfi

• File 0050-Use-AC_CHECK_HEADERS-when-HAVE_xxx_H-macro-expected.patch (File ID: 6525) is attached

2021-04-14 20:08 Updated by: cazfi

• Dono Update from (Nenhum) to cazfi
• Resolução Update from Nenhum to Accepted

Comentário

- Will push attached patch to master immediately. If CI then indicates that it fixes the OSX issue, will push also to other branches.

2021-04-14 20:25 Updated by: cazfi

• Estado Update from Aberto to Fechado
• Resolução Update from Accepted to Fixed

Comentário

Now pushed to all branches.