explain_why_no_action_enabled() fallthrough warning

• Relator: cazfi
• Dono: cazfi
• Tipo: Bugs
• Estado: Fechado
• Componente: Server
• Marcos: 3.0.0 (fechado)
• Prioridade: 5 - Medium
• Gravidade: 5 - Medium
• Resolução: Fixed
• Arquivo: 1

Details Responder

With -Wimplicit-fallthrough enabled:

../../../src/server/unithand.c: In function ‘explain_why_no_action_enabled’:
../../../src/server/unithand.c:2019:5: error: this statement may fall through -Werror=implicit-fallthrough=

2019 | {

|

../../../src/server/unithand.c:2038:3: note: here

2038 | case ANEK_TRIREME_MOVE:

| ^~

Ticket History (3/5 Histories)

2021-09-23 11:32 Updated by: cazfi

• New Ticket "explain_why_no_action_enabled() fallthrough warning" created

2021-09-23 17:16 Updated by: cazfi

Comentário Responder

This is actually dead code *after* the break;

Seems like alternative implementation to the stuff that is above. Is this reimplementing gone awry?

2021-10-09 12:58 Updated by: cazfi

• File 0041-Take-ANEK_ACT_NOT_ENOUGH_MONEY-message-reimplementat.patch (File ID: 7602) is attached

2021-10-09 12:59 Updated by: cazfi

• Resolução Update from Nenhum to Accepted
• Marco Update from (Nenhum) to 3.0.0 (fechado)

2021-10-16 14:36 Updated by: cazfi

• Estado Update from Aberto to Fechado
• Dono Update from (Nenhum) to cazfi
• Resolução Update from Accepted to Fixed