Tíquete #44082

req_text_insert(): Fallthrough from VUT_CITYSTATUS to VUT_MINLATITUDE

: 2022-03-12 22:53 Última Atualização: 2022-03-24 02:30

Relator:
Dono:
Tipo:
Estado:
Fechado
Componente:
Marcos:
Prioridade:
5 - Medium
Gravidade:
5 - Medium
Resolução:
Fixed
Arquivo:
2

Details

Compiling master with --enable-debug=checks:

../../../src/common/reqtext.c: In function ‘req_text_insert’:
../../../src/common/reqtext.c:2888:12: error: this statement may fall through (-Werror=implicit-fallthrough=)

2888 | } else {
|

../../../src/common/reqtext.c:2949:3: note: here

2949 | case VUT_MINLATITUDE:

Seems like a genuine bug; unsupported ranges just "break;" from the inner switch, and there's neither break or return after that to prevent falling through in the outer switch.

Ticket History (3/6 Histories)

2022-03-12 22:53 Updated by: cazfi
  • New Ticket "req_text_insert(): Fallthrough form VUT_CITYSTATUS to VUT_MINLATITUDE" created
2022-03-12 23:04 Updated by: cazfi
  • Dono Update from (Nenhum) to cazfi
  • Resolução Update from Nenhum to Accepted
  • Marco Update from (Nenhum) to 3.1.0 (fechado)
Comentário

Really a bug in master only, but better to clean up in S3_1 too.

2022-03-14 14:14 Updated by: cazfi
  • Summary Updated
2022-03-24 02:30 Updated by: cazfi
  • Estado Update from Aberto to Fechado
  • Resolução Update from Accepted to Fixed

Editar

You are not logged in. I you are not logged in, your comment will be treated as an anonymous post. » Login