create_command_newcomer() may break if there's no dead players

• Relator: cazfi
• Dono: cazfi
• Tipo: Bugs
• Estado: Fechado
• Componente: Server
• Marcos: 3.0.2 (fechado)
• Prioridade: 5 - Medium
• Gravidade: 5 - Medium
• Resolução: Fixed
• Arquivo: 1

Details

create_command_newcomer() may try to free player slot for the new player by removing dead player(s). This works correctly only when there's exactly one dead player. If there's none -> it still continues as if it now would have a free slot. If there's more than one -> the message about "replacing dead player" has a wrong name (last of the freed dead players, while it will replace the first one).

Ticket History (3/6 Histories)

2022-05-02 08:13 Updated by: cazfi

• New Ticket "create_command_newcomer() may break if there's no dead players" created

2022-05-02 08:28 Updated by: cazfi

• Marco Update from (Nenhum) to 3.0.2 (fechado)

2022-05-03 04:11 Updated by: cazfi

• File 0049-create_command_newcomer-Do-not-assume-one-dead-playe.patch (File ID: 9142) is attached

2022-05-03 04:11 Updated by: cazfi

• Dono Update from (Nenhum) to cazfi
• Resolução Update from Nenhum to Accepted

Comentário

Will push even to S2_6

2022-05-12 09:43 Updated by: cazfi

Comentário

Reply To cazfi

Will push even to S2_6

No, I won't. This introduces a new string, and we don't assume translators to touch S2_6 any more.

2022-05-12 10:00 Updated by: cazfi

• Estado Update from Aberto to Fechado
• Resolução Update from Accepted to Fixed