Optimize some heavy MAX() and MIN() uses

• Relator: cazfi
• Dono: cazfi
• Tipo: Patches
• Estado: Fechado
• Componente: General
• Marcos: 3.0.3 (fechado)
• Prioridade: 5 - Medium
• Gravidade: 5 - Medium
• Resolução: Fixed
• Arquivo: 3

Details

We have some MAX() and MIN() uses where one of the parameters is relatively heavy to evaluate AND such that the compiler cannot optimize away the need to do the full evaluation twice (a function call of which compiler does not know that it will return the same value both times, and has no side-effects)

Move such heavy evaluations outside the macros, to do them only once.

Ticket History (3/7 Histories)

2022-05-15 15:02 Updated by: cazfi

• New Ticket "Optimize some heavy MAX() and MIN() uses" created

2022-05-29 06:46 Updated by: cazfi

• Marco Update from (Nenhum) to 3.0.3 (fechado)

2022-06-26 20:19 Updated by: cazfi

• File 0058-Move-heavy-parameter-evaluations-out-from-MAX-MIN.patch (File ID: 9633) is attached

2022-06-26 20:20 Updated by: cazfi

• File 0034-Move-heavy-parameter-evaluations-out-from-MAX-MIN.patch (File ID: 9634) is attached

2022-06-26 20:20 Updated by: cazfi

• File 0026-Move-heavy-parameter-evaluations-out-from-MAX-MIN.patch (File ID: 9635) is attached

2022-06-26 20:22 Updated by: cazfi

• Dono Update from (Nenhum) to cazfi
• Resolução Update from Nenhum to Accepted

Comentário

For master I went through all MAX() and MIN() uses for candidates to change. For older branches I just ported those same changes, not checking if there would be additional candidates in them - except for porting gtk3.22-client changes to older gtk-clients supported only in older branches.

2022-07-05 04:55 Updated by: cazfi

• Estado Update from Aberto to Fechado
• Resolução Update from Accepted to Fixed