generate_packets.py: remove Variant members only needed on Packets

• Relator: alienvalkyrie
• Dono: alienvalkyrie
• Tipo: Patches
• Estado: Fechado
• Componente: Bootstrap
• Marcos: 3.2.0
• Prioridade: 5 - Medium
• Gravidade: 5 - Medium
• Resolução: Fixed
• Arquivo: 1

Details

Part of #43927. Some code is unnecessarily duplicated between Packets and Variants. Remove the fields and members of the Variant class that are only used on Packets, or that can be taken unmodified from the packet this is a variant of.

Ticket History (3/4 Histories)

2022-06-07 02:57 Updated by: alienvalkyrie

• New Ticket "generate_packets.py: remove Variant members only needed on Packets" created

2022-06-07 05:15 Updated by: alienvalkyrie

• File 0009-generate_packets.py-remove-superfluous-Variant-membe.patch (File ID: 9421) is attached

2022-06-07 05:16 Updated by: alienvalkyrie

• Resolução Update from Nenhum to Accepted

Comentário

Reply To alienvalkyrie

or that can be taken unmodified from the packet this is a variant of.

This patch leaves some of those fields in if they are used in a lot of places – those should be turned into properties in #44768.

2022-06-08 20:21 Updated by: alienvalkyrie

• Estado Update from Aberto to Fechado
• Resolução Update from Accepted to Fixed