Tíquete #45240

Garbage defender in send_combat()

: 2022-07-26 19:27 Última Atualização: 2022-08-10 15:26

Relator:
Dono:
Tipo:
Estado:
Fechado
Componente:
Marcos:
Prioridade:
5 - Medium
Gravidade:
5 - Medium
Resolução:
Fixed
Arquivo:
1

Details

I'm looking at map_get_seen() segfault with the new fantasy ruleset. So far it seems that pdefender in send_combat() is garbage pointer (or at least it points to garbage content), which then leads to garbage playermap pointer to access seen counters.

Ticket History (3/6 Histories)

2022-07-26 19:27 Updated by: cazfi
  • New Ticket "Garbage defender in send_combat()" created
2022-07-26 19:52 Updated by: cazfi
Comentário

It seems that unit_attack_civilian_casualties() call causes the city to get destroyed, taking supported units with it, and the failed defender was one of those.

2022-07-26 19:55 Updated by: cazfi
  • Marco Update from (Nenhum) to 3.2.0
  • Componente Update from (Nenhum) to Server
Comentário

Only master affected, as older branches do not reduce city size in case it's already 1, i.e., city never gets destroyed in that call.

2022-08-01 12:36 Updated by: cazfi
  • Dono Update from (Nenhum) to cazfi
  • Resolução Update from Nenhum to Accepted
2022-08-10 15:26 Updated by: cazfi
  • Estado Update from Aberto to Fechado
  • Resolução Update from Accepted to Fixed

Editar

You are not logged in. I you are not logged in, your comment will be treated as an anonymous post. » Login