inf magic error after a parse error in included file

• Relator: cazfi
• Dono: cazfi
• Tipo: Bugs
• Estado: Fechado
• Componente: General
• Marcos: 3.0.4 (fechado)
• Prioridade: 5 - Medium
• Gravidade: 5 - Medium
• Resolução: Fixed
• Arquivo: 1

Details

When there's a parse error in an included file, resulting in a inf_close() call to that file:

1. inf_close() gets called recursively for the including file, as per inf->included_from
2. inf_close_partial() for the included file itself does inf_sanity_check()
3. In case of FREECIV_DEBUG build, inf_sanity_check() calls itself recursively for the including file (inf->included_from)
4. As that including file was already closed in (1), the sanity check makes all kind of illegal memory accesses

Ticket History (3/6 Histories)

2022-08-22 02:29 Updated by: cazfi

• New Ticket "ing magic error after a parse error in included file" created

2022-08-22 03:54 Updated by: cazfi

• Summary Updated

2022-08-28 15:41 Updated by: cazfi

• Marco Update from (Nenhum) to 3.0.4 (fechado)

2022-09-03 11:26 Updated by: cazfi

• File 0048-Stop-inf-file-recursing-to-already-closed-including-.patch (File ID: 10228) is attached

2022-09-03 11:26 Updated by: cazfi

• Dono Update from (Nenhum) to cazfi
• Resolução Update from Nenhum to Accepted

Comentário

Going to push even to S2_6

2022-09-10 11:40 Updated by: cazfi

• Estado Update from Aberto to Fechado
• Resolução Update from Accepted to Fixed