Tíquete #45627

V_RADIUS() getting same effect value thrice

: 2022-09-10 04:28 Última Atualização: 2023-03-30 19:26

Relator:
Dono:
Tipo:
Estado:
Fechado
Componente:
Prioridade:
5 - Medium
Gravidade:
5 - Medium
Resolução:
Fixed
Arquivo:
1

Details

E.g. unit_refresh_vision() has:

V_RADIUS(get_unit_vision_at(punit, utile, V_MAIN), get_unit_vision_at(punit, utile, V_INVIS), get_unit_vision_at(punit, utile, V_SUBSURFACE));

e.g. get_unit_vision_at() gets called three times for the same unit and tile. Each call check the same EFT_UNIT_VISION_RADIUS_SQ effects, which are not affected by the layer at all (we don't have a vision layer requirement).

Ticket History (3/4 Histories)

2022-09-10 04:28 Updated by: cazfi
  • New Ticket "V_RADIUS() getting same effect value thrice" created
2023-03-25 14:54 Updated by: cazfi
  • Dono Update from (Nenhum) to cazfi
  • Resolução Update from Nenhum to Accepted
  • Marco Update from (Nenhum) to 3.1.0-beta2 (fechado)
Comentário

Patch for S3_1 and later.

Might backport also to S3_0 later, but:
- S3_0 has only two vision layers, so is not suffering from the problem so much
- No part of this S3_1+ patch applies cleanly (maybe only because S3_0 code handes just two layers everywhere, and patch tries to adjust three)
- Definitely not before 3.0.7 release - in the beginning of some cycle (for maximal testing time) or never

2023-03-30 19:26 Updated by: cazfi
  • Estado Update from Aberto to Fechado
  • Resolução Update from Accepted to Fixed

Attachment File List

Editar

Please login to add comment to this ticket » Login