action_decision_maybe_auto() wrongly assumes that actor_unit is not NULL

• Relator: cazfi
• Dono: cazfi
• Tipo: Bugs
• Estado: Fechado
• Componente: Client common
• Marcos: 3.1.0 (fechado)
• Prioridade: 5 - Medium
• Gravidade: 5 - Medium
• Resolução: Fixed
• Arquivo: 1

Details Responder

action_decision_maybe_auto() might get called with NULL actor unit if the client does not know the unit in question. Yet it assumes, both by an assert() and by using the pointer, that it's not NULL.

Likely this should be fixed on the caller side - there's no point in calling the function without a unit.

Ticket History (3/4 Histories)

2022-09-26 16:00 Updated by: cazfi

• New Ticket "action_decision_maybe_auto() wrongly assumes that actor_unit is not NULL" created

2022-09-30 09:12 Updated by: cazfi

• File 0027-Fix-action_decision_maybe_auto-NULL-dereferences.patch (File ID: 10426) is attached

2022-09-30 09:12 Updated by: cazfi

• Dono Update from (Nenhum) to cazfi
• Resolução Update from Nenhum to Accepted
• Marco Update from (Nenhum) to 3.1.0 (fechado)

2022-10-05 06:06 Updated by: cazfi

• Estado Update from Aberto to Fechado
• Resolução Update from Accepted to Fixed