Qt: mr_menu::menus_sensitive() dead code loop

• Relator: cazfi
• Dono: cazfi
• Tipo: Bugs
• Estado: Fechado
• Componente: Qt-client
• Marcos: 3.0.7 (fechado)
• Prioridade: 5 - Medium
• Gravidade: 5 - Medium
• Resolução: Fixed
• Arquivo: 1

Details

mr_menu::menus_sensitive() does not set ptile nor ptype before it iterates over focus units. Inside that iteration it does nothing when ptile not ptype is not set (they would get set the first time execution enters that block)

Ticket History (3/4 Histories)

2022-10-08 21:22 Updated by: cazfi

• New Ticket "Qt: mr_menu::menus_sensitive() dead code loop" created

2023-01-30 06:58 Updated by: cazfi

• File 0043-Qt-Correct-irrigate-mine-menu-entry-rename.patch (File ID: 11502) is attached

2023-01-30 07:00 Updated by: cazfi

• Dono Update from (Nenhum) to cazfi
• Resolução Update from Nenhum to Accepted
• Marco Update from (Nenhum) to 3.0.7 (fechado)

Comentário

The consequence is that the code renaming menu entries always considers all the focus units to be on the same tile.

2023-02-05 01:38 Updated by: cazfi

• Estado Update from Aberto to Fechado
• Resolução Update from Accepted to Fixed