Tíquete #45877

Factor unit_move_data construction from unit_move()

: 2022-10-16 06:26 Última Atualização: 2023-06-22 02:27

Relator:
Dono:
Tipo:
Estado:
Fechado
Componente:
Marcos:
Prioridade:
5 - Medium
Gravidade:
5 - Medium
Resolução:
Fixed
Arquivo:
1

Details

To be able to resolve things like https://www.hostedredmine.com/issues/736060 we need to be able to construct the unit_move_data before calling unit_move(). First step is to refactor it out from unit_move() to a separate function. Targeting to S3_0 because dependency to fixing bug mentioned earlier.

Ticket History (3/8 Histories)

2022-10-16 06:26 Updated by: cazfi
  • New Ticket "Factor unit_move_data construction from unit_move()" created
2022-10-16 06:35 Updated by: cazfi
Comentário

Also have to move out side effect of unit_data() that it actually does the move. Even when we want to collect the data earlier, we don't want unit location to be changed at the same time.

2022-11-28 05:14 Updated by: cazfi
Comentário

This turned out to be much more involved change than I expected. At this point it seems clear that it's better to live with the bug in S3_0 than to introduce this change with all the risks of introducing a lot of new bugs.

2023-01-29 02:31 Updated by: cazfi
Comentário

Reply To cazfi

Also have to move out side effect of unit_move_data() that it actually does the move.

-> #46614, dependency of this ticket.

2023-02-20 11:42 Updated by: cazfi
Comentário

Likely it's easier to fix #45876 first, and then this, than the other way around.

2023-06-14 02:30 Updated by: cazfi
  • Dono Update from (Nenhum) to cazfi
  • Resolução Update from Nenhum to Accepted
2023-06-22 02:27 Updated by: cazfi
  • Estado Update from Aberto to Fechado
  • Resolução Update from Accepted to Fixed

Editar

Please login to add comment to this ticket » Login