Segfault when starting game with current SlowScience version

• Relator: cazfi
• Dono: (Nenhum)
• Tipo: Bugs
• Estado: Aberto
• Componente: (Nenhum)
• Marcos: (Nenhum)
• Prioridade: 5 - Medium
• Gravidade: 5 - Medium
• Resolução: Nenhum
• Arquivo: Nenhum

Details Responder

S3_0 server segfaults when starting a game with SlowScience ruleset. It loads fine.

Reported by 3plus4i in https://forum.freeciv.org/f/viewtopic.php?p=106610#p106610

Ticket History (3/6 Histories)

2022-10-25 07:53 Updated by: cazfi

• New Ticket "Segfault when starting game with current SlowScience version" created

2022-10-25 07:58 Updated by: cazfi

Comentário Responder

Seems to be some kind of infinite recursion with these three functions:

#6 0x0000555555703770 in improvement_obsolete (pplayer=pplayer@entry=0x0,

pimprove=pimprove@entry=0x555555a06a38 <improvement_types+16728>, pcity=pcity@entry=0x0)
at ../../../src/common/improvement.c:384

#7 0x00005555557c8b2a in is_building_in_range (target_player=target_player@entry=0x0,

target_city=target_city@entry=0x0, target_building=0x555555a06a38 <improvement_types+16728>,
range=REQ_RANGE_PLAYER, survives=<optimized out>, source=0x555555a06a38 <improvement_types+16728>)
at ../../../src/common/requirements.c:1373

#8 0x00005555557cb3ae in is_req_active (target_player=target_player@entry=0x0,

other_player=other_player@entry=0x0, target_city=target_city@entry=0x0,
target_building=target_building@entry=0x555555a06a38 <improvement_types+16728>,
target_tile=target_tile@entry=0x0, target_unit=target_unit@entry=0x0, target_unittype=<optimized out>,
target_output=0x0, target_specialist=0x0, target_action=0x0, req=0x555556d0cd08, prob_type=RPT_CERTAIN)
at ../../../src/common/requirements.c:2836

2022-10-25 08:05 Updated by: cazfi

Comentário Responder

That's because in the buildings.ruleset Colossus is made obsolete by its own non-existence (no idea what that tries to achieve)

2022-10-25 23:59 Updated by: no0815

Comentário Responder

That line was supposed to be in reqs, not obsolete_by. I made that error when I added that line to all small wonders, already suspected that I did, because I already slipped in the line several times then. Didn't expect that to be the cause of the crash, because I didn't get an error. Had to correct it on two occasions, now it loads again

2022-10-26 11:07 Updated by: cazfi

Comentário Responder

Created a meta-ticket about the infinite-recursion with requirements cases we have -> #45974

2022-11-05 11:48 Updated by: cazfi

• Marco Update from 3.0.5 (fechado) to (Nenhum)