Tíquete #46273

Introduce counter-shares-index to reduce CPU/memory usage

: 2022-12-15 01:19 Última Atualização: 2022-12-16 04:52

Relator:
Dono:
Estado:
Aberto [Owner assigned]
Componente:
Marcos:
(Nenhum)
Prioridade:
1 - Lowest
Gravidade:
1 - Lowest
Resolução:
Nenhum
Arquivo:
4

Details

Currently, server will process each counter of the same type, but that do not make sense for some kind of counter (owned, celebrating, disorder).

This change seems to skip currently processed counter by sharing index. It also modify iterators to check index is smaller than excepted and do not process counter if so. If index is excepted, then we increase excepted value of index and process counter. By this little modifications, each kind of counters will be processed only once. To avoid this, simply change function returns if each counter of this type should share index.

Ticket History (3/8 Histories)

2022-12-15 01:19 Updated by: lachu
  • New Ticket "Introduce counter-shares-index to reduce CPU/memory usage" created
2022-12-15 01:20 Updated by: lachu
  • Gravidade Update from 5 - Medium to 1 - Lowest
2022-12-16 02:17 Updated by: lachu
Comentário

@cazfi:

0001-OSDN-TICKET-46273-S-awomir-Lach-slawek-lach.art.pl.patch(10KB)
Working version

It looks it works at least. But patch contains bad whitespaces. I send to allow test it by greater group of people.

2022-12-16 04:52 Updated by: lachu
Comentário
0001-OSDN-TICKET-46273-S-awomir-Lach-slawek-lach.art.pl.patch(10KB)
Elminates one bug causes server segfault, when there is no counters defined

Sorry I do not tested it properly. I eliminate one evident bug in my code. Code is complicated now, so I do not known if applying this patch is necessary for a while. I tested it more by now and it seems to work, but again, code is not clear, so I do not known if there is no more bugs. Somebody else must test it and read, but for that PR exist.

Attachment File List

Editar

You are not logged in. I you are not logged in, your comment will be treated as an anonymous post. » Login